Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.db: fix Database.update method #577

Merged
merged 1 commit into from
Nov 27, 2024
Merged

api.db: fix Database.update method #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from fastapi_pagination.ext.motor import paginate
from motor import motor_asyncio
from redis import asyncio as aioredis
from kernelci.api.models import EventHistory, Hierarchy, Node, parse_node_obj

Check failure on line 14 in api/db.py

View workflow job for this annotation

GitHub Actions / Lint 

Unable to import 'kernelci.api.models'
from .models import User, UserGroup


Expand Down Expand Up @@ -278,9 +278,10 @@
if obj.id is None:
raise ValueError("Cannot update object with no id")
col = self._get_collection(obj.__class__)
obj.update()
if obj.parent == obj.id:
raise ValueError("Parent cannot be the same as the object")
if obj.__class__ == Node:
obj.update()
if obj.parent == obj.id:
raise ValueError("Parent cannot be the same as the object")
res = await col.replace_one(
{'_id': ObjectId(obj.id)}, obj.dict(by_alias=True)
)
Expand Down
Loading