kube/minikube: fix Sanskar Bhushan copyright statements #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the copyright statements for Sanskar Bhushan to follow the convention of listing the copyright owners directly rather than referring to the "authors". In many cases, the authors don't own the copyright if they're writing the code as part of their work with an employer. Signed-off-by: Guillaume Tucker <[email protected]>
nuclearcat
reviewed
Aug 29, 2023
| @@ -16,9 +15,8 @@ spec: | |||
| - name: data-volume | |||
| mountPath: /data | |||
| # resource limits needs to be discussed | |||
| resources: | |||
| resources: | |||
There was a problem hiding this comment.
I think it is not related to copyright fixes and can be separate commit?
There was a problem hiding this comment.
No that's just whitespace automatically removed. It's normal for trailing whitespace to cause git noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the copyright statements for Sanskar Bhushan to follow the convention of listing the copyright owners directly rather than referring to the "authors". In many cases, the authors don't own the copyright if they're writing the code as part of their work with an employer.