k8s: Use configmap for API deployment
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
changed the title
configmap for API deploymentconfigmap for API deployment
JenySadadia
changed the title
configmap for API deploymentconfigmap for API deployment
|
Renamed script |
|
@nuclearcat @sbdtu5498 Hello, could you please take a look and review this PR? |
|
Everything seems fine to me. Just a small nit. @JenySadadia if we can change the name of clean-all.sh to tear.sh. It sounds more resonating with deploy.sh. |
sbdtu5498
reviewed
Aug 30, 2023
kube/minkube/README.md
Outdated
| @@ -137,15 +137,15 @@ kubectly apply -f api-deployment.yaml | |||
|
|
|||
| ## Cleaning up everything afterwards | |||
|
|
|||
| To clean up everything simply use the ```clean-all.sh``` script provided in the root of the kube/minikube/hack folder by running | |||
| To clean up everything simply use the ```clean-all.sh``` script provided in the root of the kube/minikube/scripts folder by running | |||
There was a problem hiding this comment.
@JenySadadia how about calling clean-all.sh tear.sh instead.
There was a problem hiding this comment.
delete-resources.sh looks more suitable to me.
|
I guess its need rebase now, as minkube changed to minikube |
added 4 commits
September 1, 2023 11:54
Fix a typo in a command to run `api` deployment. Fixes Signed-off-by: Jeny Sadadia <[email protected]>
Use `ConfigMap` to provide configuration for redis host and DB service URL. Add a manifest file to generate `configmap` named `kernelci-api-config`. API deployment will reference `REDIS_HOST` and `MONGO_SERVICE` from the configmap. Signed-off-by: Jeny Sadadia <[email protected]>
Reference configmap `kernelci-api-config` to get environment variables for redis hostname and DB service URL. Signed-off-by: Jeny Sadadia <[email protected]>
Add `kubectl` command to generate `ConfigMap` for API deployment. Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
api-configmap
branch
from
edffc54 to
ec0a01b
Compare
Rebased it. |
added 2 commits
September 1, 2023 16:26
Rename directory name containing scripts to automate deployment from `hack` to `scripts`. Update `README.md` accordingly. Signed-off-by: Jeny Sadadia <[email protected]>
Rename script from `apply-all.sh` to `deploy.sh`. The script can be used to automate API deployment in k8s. Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
api-configmap
branch
from
ec0a01b to
ca87e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes provides
ConfigMapmechanism used to configure pods efficiently.Use
ConfigMapfor providing environment variables to API deployment.Instead of adding environment variable values for Redis hostname and Mongo DB URL directly into
apideployment file, referenceConfigMapto read values.configmapapideployment file to reference configmap variableshacktoscriptsscripts/apply-all.sh