-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Winston 3.0? #74
Comments
Does anyone have any info on whether this project will be updated, or if there are any alternatives to support the winston/v3.0-papertrail integration? If not, I might start working on an updated integration to support this. Thought I'd ask around first. |
Do you think it'd be better to embrace the breaking changes and go full Winston 3.0? Or does anyone have a sense of if folks are also using the old version as well? Should there be an effort to allow backwards compatibility? |
I think backward compatibility is always a good thing, but I think that could be handled by versioning in npm with a note in the docs regarding which winston-papertrail version supports which winston version. |
Winston 3.0 has gone to production so if you do npm install winston winston-papertrail it will crash you need to do [email protected], would be good to get it to work. |
I actually haven't seen any crashing with winston 3.0 in my own tests. The usage example works with just one change: replace
Only wrinkle is that JSON is being appended to each message (on a second line), but I've opened winstonjs/winston-transport#27 about that. Am I overlooking something? As long as it still works, I'd probably favor either leaving this transport as-is or performing a complete overhaul as described in UPGRADE-3.0.md. Something more targeted (e.g. #78) would just seem to break backward compatibility without actually getting the benefits of winston 3.0. |
@markdascher Hi Mark, any news about winstonjs/winston-transport#27 ? |
Hello, I am interested in an update on this Issue as well, 👍 Let me know if there is any additional support you require. I also noticed this support works for my needs. |
Winston 3.0 is going to be released soon. It has some breaking changes for transports which makes winston-papertrail incompatible.
For example,
log
is now called with a singleinfo
object containingmessage, level
instead of a few separate variables.@kenperkins or @troy would you be so kind to adjust the plugin for the new winston version?
The text was updated successfully, but these errors were encountered: