-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winston.handleExceptions submits 'false' to papertrail. #40
Comments
I have this issue too, did you find how to fix it? |
I have the same issue. |
I have the same issue. Is there a workaround? |
There is a way to work around this, here is my winston-papertrail handleExceptions code block.
The Papertrail constructor function doesn't set exceptionsLevel so the default transport exception handling function ends up sending undefined down to Papertrail.log function. |
would also be solved by #34 |
+1 though, @brocksamson solves my problem without having to fork the repo:)
|
Note that a complete exception handling solution also requires the code changes from #44. The code above will handle uncaught exceptions because the base transport class from winston creates the serialized representation of the object. This will not work however:
See #42 for an explanation of why this fails. |
@brocksamson pull request #44 is pending for that issue |
@brocksamson - ugh, you're right. I'm actually not even getting the "false" messages now. Hopefully this will be fixed soon.......... |
Also seeing this, any chance of updating this transport? |
Good to know, thanks! |
If you're reading this message, we'd love if you can pull the current master of winston-papertrail and run it. We'll wait at least 2 weeks to see whether any issues come up from wider use of this and one other change. If you encounter problems with master which don't occur in the current release, please open a new GitHub Issue with the transcript and reference #34. |
This is live on NPM in version |
Hi,
I'm trying to use winston-papertrail to log nodejs/express unhandled exceptions but they show up as "false" in papertrail.
Code snippet:
Then I throw an exception without catching it, like this:
After spending some time looking into it I could find out that it looks like "level" is being passed as undefined into:
The text was updated successfully, but these errors were encountered: