Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Typescript w/ ESLint #100

Open
avatarneil opened this issue Nov 21, 2020 · 4 comments
Open

Convert to Typescript w/ ESLint #100

avatarneil opened this issue Nov 21, 2020 · 4 comments
Assignees
Labels
tech-debt Catch-all for code cleanup

Comments

@avatarneil
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As a new developer to the project, a combination of Typescript & ESLint would be helpful when validating possible side-effects of changes.

Describe the solution you'd like
Migrate project to Typescript with ESLint.

Describe alternatives you've considered
cries in vanilla js

@kelvinfan001
Copy link
Owner

I have limited knowledge in this area, but I've heard good things about Typescript, so definitely open to this conversion!

@avatarneil
Copy link
Collaborator Author

I have a bit of a love-hate relationship with Typescript, but it's definitely nicer than vanilla JS IMO. We can start out making the compiler rules really permissive (allow implicit any types, no strict-null checking, etc) and then migrate over time to stricter rules. There is a reasonably large project I work on which we migrated from JS -> TS about a year and a half ago, and given how large that project is relative to this one, I have high confidence the migration wouldn't be too bad!

@avatarneil
Copy link
Collaborator Author

Gonna spike a PR adding eslint/prettier project-wide with a config I like, so you can see how it looks! It's already pointing out some tiny bugs :)

@kelvinfan001
Copy link
Owner

Sounds good! Hopefully it'll help force us to clean up the project while we're at it.

It's already pointing out some tiny bugs :)

I'm fairly confident larger ones will be emerging soon.

@avatarneil avatarneil self-assigned this Nov 22, 2020
@avatarneil avatarneil added the tech-debt Catch-all for code cleanup label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Catch-all for code cleanup
Projects
None yet
Development

No branches or pull requests

2 participants