Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spot dependency from functional test #360

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror [email protected]

Ref #310

Seems like most functional test failures are around failure to acquire a spot price for an instance.
It also adds a dependency on another controller (minion-manager)
This PR removes testing for spot from functional test

Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror requested review from a team as code owners April 18, 2022 16:14
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #360 (5fcca46) into master (86b7238) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   51.43%   51.43%           
=======================================
  Files          33       33           
  Lines        4555     4555           
=======================================
  Hits         2343     2343           
  Misses       2065     2065           
  Partials      147      147           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b7238...5fcca46. Read the comment docs.

@eytan-avisror
Copy link
Collaborator Author

37 scenarios (37 passed)
212 steps (212 passed)
36m49.891582687s
testing: warning: no tests to run
PASS
ok  	github.com/keikoproj/instance-manager/test-bdd	2211.568s [no tests to run]

@eytan-avisror eytan-avisror merged commit ae893c4 into keikoproj:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants