fix: check for role attached to instance profile and create if it doe… #372
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not exist Signed-off-by: Jonah Back <[email protected]>
backjo
force-pushed
the
fix/InstanceProfile
branch
from
189db45 to
a1f6192
Compare
Signed-off-by: Jonah Back <[email protected]>
backjo
force-pushed
the
fix/InstanceProfile
branch
from
bf98b60 to
f994628
Compare
Signed-off-by: Jonah Back <[email protected]>
backjo
force-pushed
the
fix/InstanceProfile
branch
from
d42d6c9 to
fccafef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 50.38% 50.35% -0.03%
==========================================
Files 33 33
Lines 5216 5219 +3
==========================================
Hits 2628 2628
- Misses 2439 2442 +3
Partials 149 149 ☔ View full report in Codecov by Sentry. |
| @@ -224,10 +229,9 @@ func (w *AwsWorker) CreateScalingGroupRole(name string) (*iam.Role, *iam.Instanc | |||
| return createdRole, createdProfile, errors.Wrap(err, "failed to attach instance-profile") | |||
| } | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Is there an indentation problem from line 226?
eytan-avisror
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371