From 0c4d6640404df05949c7280d35948773542a74f1 Mon Sep 17 00:00:00 2001
From: sbadiger <shreyas_badiger@intuit.com>
Date: Thu, 31 Aug 2023 11:32:00 -0700
Subject: [PATCH] fix unit tests

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
---
 api/v1alpha1/instancegroup_types_test.go | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/api/v1alpha1/instancegroup_types_test.go b/api/v1alpha1/instancegroup_types_test.go
index 5a79390f..82e3607e 100644
--- a/api/v1alpha1/instancegroup_types_test.go
+++ b/api/v1alpha1/instancegroup_types_test.go
@@ -26,7 +26,7 @@ type EksUnitTest struct {
 }
 
 func (u *EksUnitTest) Run(t *testing.T) string {
-	err := u.InstanceGroup.Validate(&ValidationOverrides{})
+	err := u.InstanceGroup.Validate(u.Overrides)
 	if err == nil {
 		return aws.StringValue(nil)
 	} else {
@@ -480,7 +480,7 @@ func TestScalingConfigOverride(t *testing.T) {
 		{
 			name: "override default to launchconfig instead of launchtemplate",
 			args: args{
-				instancegroup: MockInstanceGroup("eks-fargate", "managed", nil, nil, basicFargateSpec()),
+				instancegroup: MockInstanceGroup("eks", "managed", MockEKSSpec(), nil, basicFargateSpec()),
 				overrides: &ValidationOverrides{
 					scalingConfigurationOverride: &launchconfiguration,
 				},
@@ -490,15 +490,15 @@ func TestScalingConfigOverride(t *testing.T) {
 		{
 			name: "no default overrides",
 			args: args{
-				instancegroup: MockInstanceGroup("eks-fargate", "managed", nil, nil, basicFargateSpec()),
-				overrides:     &ValidationOverrides{},
+				instancegroup: MockInstanceGroup("eks", "managed", MockEKSSpec(), nil, basicFargateSpec()),
+				overrides: &ValidationOverrides{},
 			},
 			want: LaunchTemplate,
 		},
 		{
 			name: "override default to launchtemplate",
 			args: args{
-				instancegroup: MockInstanceGroup("eks-fargate", "managed", nil, nil, basicFargateSpec()),
+				instancegroup: MockInstanceGroup("eks", "managed", MockEKSSpec(), nil, basicFargateSpec()),
 				overrides: &ValidationOverrides{
 					scalingConfigurationOverride: &launchtemplate,
 				},
@@ -585,3 +585,17 @@ func MockInstanceGroup(provisioner, strategy string, eksSpec *EKSSpec, eksManage
 	}
 
 }
+
+func MockEKSSpec() *EKSSpec {
+	return &EKSSpec{
+		Type: "invalid-scaling-config",
+		EKSConfiguration: &EKSConfiguration{
+			EksClusterName:     "sample-cluster",
+			Subnets:            []string{"subnet-1111111", "subnet-222222"},
+			NodeSecurityGroups: []string{"sg-sample-1", "sg-sample-2"},
+			Image:              "sample-ami",
+			InstanceType:       "sample-instance",
+			KeyPairName:        "sample-key-pair",
+		},
+	}
+}