You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PostgreSQL type conversion in PostgreSQLJDBCDatatypeImporter imports varchar as CHARACTER VARYING and text as CHARACTER LARGE OBJECT. However, because SQL:1999 distincts between CHARACTER and NATIONAL CHARACTER, and PostgreSQL does not, the conversion should default to NATIONAL CHARACTER.
I haven't tried, but I believe this could break migration of SIARD archives from PostgreSQL databases to databases that distinct between VARCHAR and NVARCHAR if cells contains non-ASCII characters..
Of course, NATIONAL CHARACTER is not always what you'll want, e.g. if the database encoding is not a Unicode type or the column is just an enum.
I suggest that the type conversion methods should take the schema, table, and column as arguments, and that the PostgreSQL importer should have an option to make the following query to determine if a text column holds national characters:
PostgreSQL type conversion in
PostgreSQLJDBCDatatypeImporter
importsvarchar
asCHARACTER VARYING
andtext
asCHARACTER LARGE OBJECT
. However, because SQL:1999 distincts betweenCHARACTER
andNATIONAL CHARACTER
, and PostgreSQL does not, the conversion should default toNATIONAL CHARACTER
.I haven't tried, but I believe this could break migration of SIARD archives from PostgreSQL databases to databases that distinct between
VARCHAR
andNVARCHAR
if cells contains non-ASCII characters..Of course,
NATIONAL CHARACTER
is not always what you'll want, e.g. if the database encoding is not a Unicode type or the column is just an enum.I suggest that the type conversion methods should take the schema, table, and column as arguments, and that the PostgreSQL importer should have an option to make the following query to determine if a text column holds national characters:
This will of course very much slow down the import and should probably be an opt in.
The text was updated successfully, but these errors were encountered: