From 60f63348cfb076d20f635aa6dfcafb7e486e3537 Mon Sep 17 00:00:00 2001 From: Chris Keckler Date: Wed, 24 Jan 2024 14:09:45 -0600 Subject: [PATCH 1/4] Change impl description voicing Co-authored-by: bsculac <102382931+bsculac@users.noreply.github.com> --- armi/physics/fuelCycle/fuelHandlers.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/armi/physics/fuelCycle/fuelHandlers.py b/armi/physics/fuelCycle/fuelHandlers.py index a70c14517..0756cd79a 100644 --- a/armi/physics/fuelCycle/fuelHandlers.py +++ b/armi/physics/fuelCycle/fuelHandlers.py @@ -737,12 +737,12 @@ def swapAssemblies(self, a1, a2): :implements: R_ARMI_SHUFFLE_STATIONARY Before assemblies are moved, - calls to the ``_transferStationaryBlocks`` class method to + the ``_transferStationaryBlocks`` class method is called to check if there are any block types specified by the user as stationary - via the ``stationaryBlockFlags`` case setting. Using these flags, gather - blocks from each assembly which should remain stationary and check - to make sure that both assemblies have the same number and same - height of stationary blocks. If not, return an error. + via the ``stationaryBlockFlags`` case setting. Using these flags, blocks + are gathered from each assembly which should remain stationary and + checked to make sure that both assemblies have the same number + and same height of stationary blocks. If not, return an error. If all checks pass, use the :py:meth:`~armi.reactor.assemblies.Assembly.remove` and :py:meth:`~armi.reactor.assemblies.Assembly.insert`` From 46de12de0d40b503bae8946dbf32584fdb88a8e9 Mon Sep 17 00:00:00 2001 From: Chris Keckler Date: Wed, 24 Jan 2024 14:10:08 -0600 Subject: [PATCH 2/4] Update armi/physics/fuelCycle/fuelHandlers.py Co-authored-by: bsculac <102382931+bsculac@users.noreply.github.com> --- armi/physics/fuelCycle/fuelHandlers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/armi/physics/fuelCycle/fuelHandlers.py b/armi/physics/fuelCycle/fuelHandlers.py index 0756cd79a..24ddd8d3e 100644 --- a/armi/physics/fuelCycle/fuelHandlers.py +++ b/armi/physics/fuelCycle/fuelHandlers.py @@ -744,9 +744,9 @@ def swapAssemblies(self, a1, a2): checked to make sure that both assemblies have the same number and same height of stationary blocks. If not, return an error. - If all checks pass, use the :py:meth:`~armi.reactor.assemblies.Assembly.remove` + If all checks pass, the :py:meth:`~armi.reactor.assemblies.Assembly.remove` and :py:meth:`~armi.reactor.assemblies.Assembly.insert`` - methods to swap the stationary blocks between the two assemblies. + methods are used to swap the stationary blocks between the two assemblies. Once this process is complete, the actual assembly movement can take place. Through this process, the stationary blocks remain in the same From 795caad9adb52a0f31e1458ac52442f9945bdee2 Mon Sep 17 00:00:00 2001 From: Chris Keckler Date: Wed, 24 Jan 2024 14:10:33 -0600 Subject: [PATCH 3/4] Update armi/physics/fuelCycle/fuelHandlers.py Co-authored-by: bsculac <102382931+bsculac@users.noreply.github.com> --- armi/physics/fuelCycle/fuelHandlers.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/armi/physics/fuelCycle/fuelHandlers.py b/armi/physics/fuelCycle/fuelHandlers.py index 24ddd8d3e..a629d4859 100644 --- a/armi/physics/fuelCycle/fuelHandlers.py +++ b/armi/physics/fuelCycle/fuelHandlers.py @@ -852,12 +852,12 @@ def dischargeSwap(self, incoming, outgoing): :implements: R_ARMI_SHUFFLE_STATIONARY Before assemblies are moved, - calls to the ``_transferStationaryBlocks`` class method to + the ``_transferStationaryBlocks`` class method is called to check if there are any block types specified by the user as stationary - via the ``stationaryBlockFlags`` case setting. Using these flags, gather - blocks from each assembly which should remain stationary and check - to make sure that both assemblies have the same number and same - height of stationary blocks. If not, return an error. + via the ``stationaryBlockFlags`` case setting. Using these flags, blocks + are gathered from each assembly which should remain stationary and + checked to make sure that both assemblies have the same number + and same height of stationary blocks. If not, return an error. If all checks pass, use the :py:meth`~armi.reactor.assemblies.Assembly.remove` and :py:meth:`~armi.reactor.assemblies.Assembly.insert`` From 03aeaa97d49a9b7b86aae06aef3f99e63850b76e Mon Sep 17 00:00:00 2001 From: Chris Keckler Date: Wed, 24 Jan 2024 14:10:46 -0600 Subject: [PATCH 4/4] Update armi/physics/fuelCycle/fuelHandlers.py Co-authored-by: bsculac <102382931+bsculac@users.noreply.github.com> --- armi/physics/fuelCycle/fuelHandlers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/armi/physics/fuelCycle/fuelHandlers.py b/armi/physics/fuelCycle/fuelHandlers.py index a629d4859..d0cb477e0 100644 --- a/armi/physics/fuelCycle/fuelHandlers.py +++ b/armi/physics/fuelCycle/fuelHandlers.py @@ -859,9 +859,9 @@ def dischargeSwap(self, incoming, outgoing): checked to make sure that both assemblies have the same number and same height of stationary blocks. If not, return an error. - If all checks pass, use the :py:meth`~armi.reactor.assemblies.Assembly.remove` + If all checks pass, the :py:meth:`~armi.reactor.assemblies.Assembly.remove` and :py:meth:`~armi.reactor.assemblies.Assembly.insert`` - methods to swap the stationary blocks between the two assemblies. + methods are used to swap the stationary blocks between the two assemblies. Once this process is complete, the actual assembly movement can take place. Through this process, the stationary blocks from the outgoing