Remove support for comments in JSON configuration files

Remove dependency on unmaintained `commentjson`
Closes #1152

changelog.md

@@ -5,6 +5,8 @@
 > [!IMPORTANT]
 > This version is not released yet and is under active development.
 
+- Remove support for comments in JSON configuration files. Remove dependency on unmaintained `commentjson`. Closes [`click-extra#1152`](https://github.com/kdeldycke/click-extra/issues/1152).
+
 ## [4.11.6 (2024-11-28)](https://github.com/kdeldycke/click-extra/compare/v4.11.5...v4.11.6)
 
 - Make `--timer` option eager so it can jumps the queue of processing order.

click_extra/config.py

@@ -18,6 +18,7 @@
 from __future__ import annotations
 
 import logging
+import json
 import os
 import sys
 from configparser import ConfigParser, ExtendedInterpolation
@@ -32,7 +33,6 @@
 else:
     import tomli as tomllib  # type: ignore[import-not-found]
 
-import commentjson as json
 import requests
 import xmltodict
 import yaml

pyproject.toml

@@ -73,7 +73,6 @@ dependencies = [
     "click ~= 8.1.4",
     # Cloup 3.0.5 fix incompatibility with autodoc: https://github.com/janluke/cloup/issues/177
     "cloup ~= 3.0.5",
-    "commentjson ~= 0.9.0",
     "extra-platforms ~= 1.6.0",
     "mergedeep ~= 1.3.4",
     "pyyaml ~= 6.0.0",
@@ -189,13 +188,7 @@ pretty = true
 
 [[tool.mypy.overrides]]
 ignore_missing_imports = true
-module = [
-    "boltons.*",
-    "commentjson.*",
-    "furo",
-    "mergedeep.*",
-    "pallets_sphinx_themes.*",
-]
+module = ["boltons.*", "furo", "mergedeep.*", "pallets_sphinx_themes.*"]
 
 [tool.pytest.ini_options]
 # https://docs.pytest.org/en/latest/customize.html#pyproject-toml

readme.md

@@ -37,7 +37,7 @@ To undestrand how we ended up with the result above, [go read the tutorial](http
 - [Configuration file](https://kdeldycke.github.io/click-extra/config.html) loader for:
   - `TOML`
   - `YAML`
-  - `JSON`, with inline and block comments (Python-style `#` and Javascript-style `//`)
+  - `JSON`
   - `INI`, with extended interpolation, multi-level sections and non-native types (`list`, `set`, …)
   - `XML`
 - Automatic inference of the configuration file structure from your CLI's options

tests/test_config.py

@@ -131,16 +131,14 @@
                     "npm",
                     "gem"
                 ],
-                "verbosity": "DEBUG",   // log level
+                "verbosity": "DEBUG",
 
-                # Subcommand config
                 "default-command": {
                     "int_param": 3,
                     "random_stuff": "will be ignored"
                 }
             },
 
-            // Section to ignore
             "garbage": {}
         }
         """,