-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add country geoip lookup for endpoint addresses #6
Conversation
furmur
commented
Mar 26, 2024
- add CLI option 'geoip_path' to specify Country MMDB path
- add attribute 'endpoint_country' to the 'wireguard_peer_endpoint' metric if 'geoip_path' was specified
* add CLI option 'geoip_path' to specify Country MMDB path * add attribute 'endpoint_country' to the 'wireguard_peer_endpoint' metric if 'geoip_path' was specified
Very cool idea but two general comments:
|
Also looks like this PR bumps the MSRV to 1.58.1 which is fine, but we need to set that new value in CI. |
thank you for reviewing. fixed issues you mentioned. strace for
|
Ah ok, good to know. It's possible that if we're looking at the same several IPs over-and-over some kind of caching layer would be a better long term approach as the caching layer, even naively implemented as a linear search would be However, I think that extra complication is fine to do without at least until we have some actual numbers and know if it'd be worth it or not. I'm good with this merge, and I really appreciate your taking the time to put this together. I'll get a new version released hopefully tonight but feel free to ping me if you don't see one in the next few days. |
@kbknapp Could you release new version with this feature? |
@dmitry-sinina thanks for the ping - v0.3.0 is out now on both crates.io and this project's release page. |