Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greeting and starting the reviewing process 👋 #5

Open
hoangnguyen92dn opened this issue Dec 24, 2021 · 5 comments
Open

Greeting and starting the reviewing process 👋 #5

hoangnguyen92dn opened this issue Dec 24, 2021 · 5 comments

Comments

@hoangnguyen92dn
Copy link

Hello Kaung Khant Soe,

Nice to e-meet you 👋 and thanks for your effort on this submission. My name is Huey - an Android Developer at Nimble and I would like to conduct the feedback via Issue tickets regarding your performance here.

Keep in mind, this is a bidirectional process, so we would love to hear back from you as well, so please don’t hesitate to raise your question/correction in case we missed anything.

If we’re aligned on any issue here and you’d like to correct them, please go ahead and open a Pull Request per fix, merge it when you feel confident and we will follow up on those fixes 😇

I hope you find the process enjoyable. Good luck and happy coding 🤘

@kaungkhantsoe
Copy link
Owner

Hello Huey,
Nice to e-meet you too 😊. I am ready for the process and I will do my best for the fixes. Thank you for your time and efforts for reviewing the submission.😇

@hoangnguyen92dn
Copy link
Author

hoangnguyen92dn commented Dec 24, 2021

@kaungkhantsoe I am finished my 1st round of code review 😄 Don't hesitate to lemme know if you have any concerns need to clarify. Regarding the time frame to resolve the created issues, you could follow up with our HR if you have your personal plan and need to deal with the deadline. 😄

☃️ Btw, Santa Claus is coming to town, Merry Christmas Eve! 🎉 🎅

@kaungkhantsoe
Copy link
Owner

@hoangnguyen92dn I've finished solving all the issues. Thank you for your time and pointing out the issues for me.

☃️ Merry Christmas Eve! 🎉

@hoangnguyen92dn
Copy link
Author

@kaungkhantsoe Thanks for your updating. I will review the code changes and finalize my review of your challenge. Have a nice day ☀️

@kaungkhantsoe
Copy link
Owner

@hoangnguyen92dn Thank you. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants