Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please port to Python3 #122

Open
tillea opened this issue Sep 2, 2019 · 2 comments
Open

Please port to Python3 #122

tillea opened this issue Sep 2, 2019 · 2 comments

Comments

@tillea
Copy link

tillea commented Sep 2, 2019

Hello,
the Debian Med team is maintaining srst2 for official Debian. The recently released Debian 10 was the last Debian release featuring Python2 since this programming language is EOL. If you are interested that we continue to maintain srst2 in official Debian (and that users of other modern distributions will have no problems to install srst2 on their systems) I'd recommend you port your code to Python3. I confirm I have read issue #105 where you are stating that stst2 is written in Python2 - but a conversion using the 2to3 tool is usually not very complex and it increases the chances of usage in the long term.
Kind regards, Andreas.

@tillea
Copy link
Author

tillea commented Dec 11, 2019

Hi,
for the Debian package I've used 2to3 and some manual editing to create a patch which passes the unit tests provided by you with Python3.
Feel free to cherry-pick from this, Andreas.

@katholt
Copy link
Owner

katholt commented Dec 11, 2019

Thanks Andreas. I really appreciate this - we simply haven't had time to try porting, but we will do some testing of this patch and hopefully can update srst2 release to python3 in the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants