Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kas = {git = "https://github.com/kas-gui/kas"} is broken, winit patch is not applied #414

Closed
m-hugo opened this issue Oct 18, 2023 · 1 comment

Comments

@m-hugo
Copy link

m-hugo commented Oct 18, 2023

adding master kas to a crate as

[dependencies]
kas = {git = "https://github.com/kas-gui/kas"}

fails because this patch from the root's Cargo.toml isn't applied so the regular winit v0.29.1-beta is used

[patch.crates-io.winit]
git = "https://github.com/rust-windowing/winit.git"
rev = "cb58c49a90f17734e0405627130674d47c0b8f40"

adding manually the patch to my crate's Cargo.toml made it work

@dhardy
Copy link
Collaborator

dhardy commented Oct 19, 2023

Thanks for the report; guess I shouldn't merge patches like that. It could be fixed (remove the patch, adjust the import in crates/kas-core/Cargo.toml instead), but hopefully Winit 0.29 won't be too long now: rust-windowing/winit#2686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants