Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe Generator Button got lost #226

Closed
2 tasks
wellemut opened this issue Aug 24, 2024 · 3 comments
Closed
2 tasks

Iframe Generator Button got lost #226

wellemut opened this issue Aug 24, 2024 · 3 comments
Assignees
Labels
0 bug Something isn't working

Comments

@wellemut
Copy link
Member

wellemut commented Aug 24, 2024

Problem

The Button "iframe" got lost in the sharing menu
grafik

instead there is the subscribe-button, which endpoint is not working yet.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the map https://www.kartevonmorgen.org/m/kvm?c=50.8198%2C5.6030&z=6.00
  2. Click on "share" down right
  3. you cant find "share iframe code"

Expected behavior

In dependently, if the "subscribe" button is activ or not, the "Embedd as ifrmes" button should never disappear
Image

Additional context
I guess, the problem came with the last release, when some dependencies were "rolled back" v1.2.7...v1.2.8

Definiton of Done

@wellemut wellemut added the 0 bug Something isn't working label Aug 24, 2024
@wellemut wellemut moved this from New Issues to Review in Improvements after Refactoring Aug 24, 2024
@wellemut
Copy link
Member Author

@navid-kalaei please checkout, what could be the reason and estimate a story point number, how easy we could fix it?...

@wellemut wellemut changed the title [BUG] Iframe Generator Button got lost Iframe Generator Button got lost Aug 24, 2024
@navid-kalaei
Copy link
Collaborator

@wellemut it was my error during the development. I have made the subscription almost ready and before pushing to the production level I accidentally disable the sharing button disable instead. I made it back on commit 798439b

@wellemut
Copy link
Member Author

Thank you for fixing it @navid-kalaei
It happens...

Screenshot_20240923-214933~2.png
Button is back again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 bug Something isn't working
Projects
Development

No branches or pull requests

2 participants