Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded apostrophe in values get removed. (included fix below) #3

Open
nthdominion opened this issue May 15, 2018 · 0 comments
Open

Comments

@nthdominion
Copy link

Using a value that has embedded single ticks, the ticks will be wiped when using the following example:
[CustomAttributes.ConditionalRequired("Field=='Doctor's Office'" ...

This should come out to "Doctor's Office", not "Doctors Office" due to the unguarded/greedy string.replalce() used. Only the first/last tick should be removed.

Fix: change ExpressionParser._GetValue()
OLD:
if (valueString.StartsWith("'") && valueString.EndsWith("'"))
return valueString.Replace("'", string.Empty);
NEW:
if (valueString.StartsWith("'") && valueString.EndsWith("'"))
return valueString.Substring(1, valueString.Length - 2);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant