Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strict .use() #579

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: strict .use() #579

merged 2 commits into from
Jan 6, 2025

Conversation

lajbel
Copy link
Collaborator

@lajbel lajbel commented Jan 3, 2025

This changes applies for both versions, v3001 and v4000 and makes strict() only acceept type object or string, otherwise will throw an error. I hope it will help with cases like passing smt is returning undefined, or an extra comma.

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@579

commit: 2f94693

@lajbel lajbel added the crossplay Something that should be in both versions, v3001 and v4000 label Jan 3, 2025
@lajbel lajbel requested a review from mflerackers January 3, 2025 13:46
Copy link
Member

@mflerackers mflerackers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is also typeof "object"

@lajbel lajbel requested a review from mflerackers January 4, 2025 15:00
@lajbel lajbel merged commit f2e02e6 into master Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crossplay Something that should be in both versions, v3001 and v4000
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

2 participants