Replace play-json with nanojson in kamon-datadog?

[dvgica]

Hey all,

The kamon-datadog module relies on play-json for serialization. It appears to be the only such module, and I'm wondering if we should try to consolidate on a single JSON library. The kamon-akka-http module uses json4s so that might be a good candidate.

It does look like nanojson is also used. But, json4s at least makes it a bit easier to switch backends if needed.

This stems from a dependency conflict I'm having with the play-json pulled in by Kamon, and one already in my app.

Thoughts?

[dvgica]

Whoops, just realized that json4s is being used in a test context. So maybe nanojson would be better.

[ivantopo]

I don't see any particular reason not to switch the library. Our general stance is that the less libraries we have as dependencies, the better. The dependency on play-json was initially brought in by this PR.

@stoiev do you maybe face any issues with using other json libraries or see any inconvenience in changing it?

[dvgica]

Cool. The replacement with nanojson looks pretty straight-forward to me, there's a very small amount of JSON to write. I can write a PR if there's no concerns about the idea.

[stoiev]

I see no issue/inconvenience. This lib was choose primarily because is under play umbrella - which I believed to be well known/maintained. If there is another json library already in use in Kamon, I agree that it's better to remove it and avoid extra bloat.

[dvgica]

PR up here, feedback welcome! #892