Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String deprecation #408

Open
haietza opened this issue Nov 2, 2023 · 2 comments
Open

String deprecation #408

haietza opened this issue Nov 2, 2023 · 2 comments

Comments

@haietza
Copy link
Contributor

haietza commented Nov 2, 2023

In the Kaltura media assignment, when feedback is viewed the following deprecation warning is output:

String [grade,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation

line 397 of /lib/classes/string_manager_standard.php: call to debugging()
line 7414 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 1129 of /mod/kalvidassign/renderer.php: call to get_string()
line 98 of /mod/kalvidassign/view.php: call to mod_kalvidassign_renderer->display_grade_feedback()
@lucaboesch
Copy link
Contributor

lucaboesch commented Nov 2, 2023

Yeah.
The pull request is awaiting merge for over two years, see #342, now #434.

@haietza
Copy link
Contributor Author

haietza commented Nov 3, 2023

Sorry @lucaboesch I searched previous issues and didn't come across that one. Two years sounds about right for Kaltura response to issues :(.

lucaboesch added a commit to lucaboesch/moodle_plugin that referenced this issue Feb 5, 2024
lucaboesch added a commit to lucaboesch/moodle_plugin that referenced this issue Feb 5, 2024
lucaboesch added a commit to lucaboesch/moodle_plugin that referenced this issue May 26, 2024
lucaboesch added a commit to lucaboesch/moodle_plugin that referenced this issue Aug 4, 2024
lucaboesch added a commit to lucaboesch/moodle_plugin that referenced this issue Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants