Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ring::read_and_consume #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Ring::read_and_consume #38

wants to merge 1 commit into from

Conversation

tikste
Copy link

@tikste tikste commented Mar 17, 2024

Hi,

I need to get a reference of a portion of the underlying data of a Ring and consume it at the same time for seamless support of zero-copy parsing.

It could be implemented in trait SeqRead instead. In this case one should call self.consume(len) in line 96.

Regards,
Till

kalamay
kalamay approved these changes Apr 13, 2024
View reviewed changes
Copy link
Owner

@kalamay kalamay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalamay kalamay kalamay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikste @kalamay