pkp/pkp-lib#10511 Avoid running queries if there's nothing to process

kaitlinnewson · Nov 29, 2024 · dc49076 · dc49076
1 parent b740084
commit dc49076
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/classes/migration/upgrade/v3_5_0/I10511_RemoveSeriesMenuItems.php b/classes/migration/upgrade/v3_5_0/I10511_RemoveSeriesMenuItems.php
@@ -32,6 +32,10 @@ public function up(): void
                 $query->select('series_id')->from('series');
             })->pluck('navigation_menu_item_id');
 
+        if (!$invalidNavigationMenuItemIds->count()) {
+            return;
+        }
+
         DB::table('navigation_menu_item_assignments')
             ->whereIn('parent_id', $invalidNavigationMenuItemIds)
             ->update(['parent_id' => null]);