Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brokers: Configs: Improvements #50

Closed
Haarolean opened this issue Jan 24, 2024 · 0 comments · Fixed by #179
Closed

Brokers: Configs: Improvements #50

Haarolean opened this issue Jan 24, 2024 · 0 comments · Fixed by #179
Assignees
@Leshe4ka
Labels
good first issue Up for grabs scope/frontend Related to frontend changes type/enhancement En enhancement/improvement to an already existing feature
Milestone
1.0

Comments

@Haarolean
Copy link
Member

Haarolean commented Jan 24, 2024 •
edited
Loading

  • display friendly units (sizes, time units)

All keys with ".bytes" in the name are sizes
All keys with ".ms" in the name are time units

  • replace enums with human friendly string for source tooltips
image Just use the human readable values, like DEFAULT_CONFIG -> "Default config"
  • Display "changed first" (based on source)

Order priority:

  1. DYNAMIC_* source
  2. STATIC_BROKER_CONFIG source
  3. DEFAULT_CONFIG being last
  4. UNKNOWN

  • Allow manual sorting by source

  • Mask sensitive params values by default (isSensitive: true)

  • Make r/o fields (isReadOnly: true) uneditable (disable the button with "Property is read-only" tooltip)
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 24, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/enhancement En enhancement/improvement to an already existing feature and removed status/triage Issues pending maintainers triage labels Jan 24, 2024
@Haarolean Haarolean added this to the 1.0 milestone Jan 24, 2024
@Haarolean Haarolean added the good first issue Up for grabs label Jan 24, 2024
@Haarolean Haarolean moved this to Todo in Release 1.0 Jan 24, 2024
@Haarolean Haarolean moved this from Todo to In Development in Release 1.0 Feb 21, 2024
@Haarolean Haarolean moved this to Beginner in Up for grabs Feb 21, 2024
@Haarolean Haarolean linked a pull request Mar 1, 2024 that will close this issue
FE: Brokers: Configs: Improvements #179
Merged
13 tasks
@Haarolean Haarolean moved this from In Development to In Review in Release 1.0 Mar 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Release 1.0 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leshe4ka Leshe4ka

Labels
good first issue Up for grabs scope/frontend Related to frontend changes type/enhancement En enhancement/improvement to an already existing feature
Projects
Up for grabs
Status: In Development
Release 1.0
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

FE: Brokers: Configs: Improvements kafbat/kafka-ui
2 participants
@Haarolean @Leshe4ka