New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compilation error when mixing component lifecycle methods #34

Open

kLabz opened this issue Nov 28, 2019 · 0 comments

Owner

kLabz commented Nov 28, 2019

React will give the following runtime error:

Warning: Unsafe legacy lifecycles will not be called for components using new component APIs.

MyComponent uses getDerivedStateFromProps() but also contains the following legacy lifecycles:
  componentWillMount

The above lifecycles should be removed. Learn more about this warning here:
https://fb.me/react-unsafe-component-lifecycles

These could (and should) be catched at compile time.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment