Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent defaultProps behavior in debug / no debug mode #32

Open
djaonourside opened this issue Oct 13, 2019 · 2 comments
Open

Inconsistent defaultProps behavior in debug / no debug mode #32

djaonourside opened this issue Oct 13, 2019 · 2 comments

Comments

@djaonourside
Copy link

Hi, Rudy! It looks like react-next has this bug too.
massive-oss#131

@kLabz
Copy link
Owner

kLabz commented Oct 14, 2019

Can you check if latest git (with this commit 138cc01) fixes your original issue and works for your project?

If it works I'll make a PR to haxe-react too. Note that this won't be the final fix; I still need to add tests to check other cases (spreads, etc.) and this can be optimized (by skipping constant arguments, etc.). I might end up calling a "native" Object.assign to get the same behavior as react's.

@djaonourside
Copy link
Author

Confirm, the fix solves the issue for my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants