Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost Status updates, add datacenter contextName #1466

Open
burmanm opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1461
Open

Lost Status updates, add datacenter contextName #1466

burmanm opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1461
Assignees
Labels
bug Something isn't working

Comments

@burmanm
Copy link
Contributor

burmanm commented Dec 11, 2024

What happened?
ContextName is missing from our Datacenter status, so if the user deletes the datacenters[] part of the DC, we can no longer necessarily pick up the correct target context.

As for missing status updates, there are a lot.

In the datacenters.go, we don't actually use the updated value of kdcStatus, we simply copy stuff to it but do not reassign that new value (since a new reference was created with := earlier). As such that status update is entirely lost.

In reaper.go and stargate.go, we update the entire Status part and then miss any fields that might have been set previously. This was clear when I modified the tests to check status fields and they were not there when 10 seconds earlier those fields were there (such as the context). Thus, we need to copy the Stargate info to existing Status, not overwrite the entire Status with just what Stargate had in mind. Also, some updates in the stargate.go were also missing due to the same issue as in datacenters.go, where the new reference was never actually set back to the kcObject.Status.

Did you expect to see something different?

How to reproduce it (as minimally and precisely as possible):

Environment

  • K8ssandra Operator version:

    Insert image tag or Git SHA here

  • Kubernetes version information:

    kubectl version

  • Kubernetes cluster kind:

    insert how you created your cluster: kops, bootkube, etc.

  • Manifests:

insert manifests relevant to the issue
  • K8ssandra Operator Logs:
insert K8ssandra Operator logs relevant to the issue here

Anything else we need to know?:

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: K8OP-300

@burmanm burmanm added the bug Something isn't working label Dec 11, 2024
@burmanm burmanm self-assigned this Dec 11, 2024
@burmanm burmanm linked a pull request Dec 11, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant