-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC names are not properly sanitized #1141
Comments
adejanovski
added
in-progress
Issues in the state 'in-progress'
and removed
ready
Issues in the state 'ready'
labels
Mar 15, 2024
olim7t
added a commit
to olim7t/k8ssandra-operator
that referenced
this issue
Mar 15, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
in-progress
Issues in the state 'in-progress'
labels
Mar 16, 2024
adejanovski
added
in-progress
Issues in the state 'in-progress'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Mar 18, 2024
olim7t
added a commit
to olim7t/k8ssandra-operator
that referenced
this issue
Mar 18, 2024
- reject cluster creation if a DC has an invalid name - always use sanitized DC name override when naming secondary resources - use cluster name override for metrics agent configMap Fixes k8ssandra#1138 Fixes k8ssandra#1141
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
in-progress
Issues in the state 'in-progress'
labels
Mar 18, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Mar 18, 2024
olim7t
added a commit
that referenced
this issue
Mar 19, 2024
adejanovski
added
done
Issues in the state 'done'
and removed
review
Issues in the state 'review'
labels
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a cluster declares a datacenter with invalid characters:
The name is not properly sanitized, which leads to this error:
The problem is not limited to that ConfigMap: even after fixing it (here), the invalid name causes another error when the operator tries to create the
CassandraDatacenter
.We should either reject invalid DC names in the validation webhook, or sanitize them and maybe use the original value as the
datacenterName
.The text was updated successfully, but these errors were encountered: