Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines separating octaves width #3

Open
sugizo opened this issue Aug 31, 2023 · 0 comments
Open

lines separating octaves width #3

sugizo opened this issue Aug 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sugizo
Copy link

sugizo commented Aug 31, 2023

problems with lines separating octaves width
when changing the resolution
400 x 300
image

hd 1920 x 1080
image

4k 3840 x 2160
image

8k 7680 x 4320
image

suggestion
make dynamic or responsive lines separating octaves width
e.g.
synthviz/main.py

        # draw lines separating octaves
        if i % 12 == 0:
            im_lines[0:(key_start-1), (x0-2):(x0-1)] = [20, 20, 20]

im_lines[0:(key_start-1), (x0-2):(x0-1)]
should be

line_width = 9 # or whatever value from user entry (or you can hard code it, in scale of the picture width)
im_lines[0:(key_start - 1), (x0 - line_width):(x0 - 1) ]

best regards

@jxmorris12 jxmorris12 added the enhancement New feature or request label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants