Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output video only show note on clef g (higher note) #1

Open
sugizo opened this issue Aug 18, 2023 · 3 comments
Open

output video only show note on clef g (higher note) #1

sugizo opened this issue Aug 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@sugizo
Copy link

sugizo commented Aug 18, 2023

the same midi, produce different result in the key pressed

result
in synthviz there is no note in clef f pressed (lower note)
image

expected
should be with the note in clef f pressed for lower note
image

best regards

@sugizo
Copy link
Author

sugizo commented Aug 18, 2023

test1.mp4 from only clef g (higher note pressed)

test1.mp4

test2.mp4 from only clef f (lower notes pressed simultanously or chord)

test2.mp4

test0.mp4 from complete midi (clef g (higher note pressed) and clef f (lower notes pressed simultanously or chord) )
this one is the problem report on first post, because lower notes not shown

test0.mp4

p.s.
everything is from same midi,
just separate it using musescore
then
export it as separate midi then create it with synthviz

best regards

@jxmorris12 jxmorris12 added the bug Something isn't working label Aug 26, 2023
@sugizo
Copy link
Author

sugizo commented Aug 27, 2023

perhaps the problem is in
synthviz/main.py

	notes = [
		{ "note": n.pitch, "start": n.start, "end": n.end}
		for n in midi_data.instruments[0].notes
	]

midi_data.instruments[0].notes

it only load the first instrument

it should be

    notes = []

    for instrument in midi_data.instruments:
        for n in instrument.notes:
            notes.append({"note": n.pitch, "start": n.start, "end": n.end} )

i've modified a lot from your code, could share, if you interest

here is the result
https://www.youtube.com/watch?v=aDR29fh6erY

best regards

@jxmorris12
Copy link
Owner

ah thanks for investigating! Yes would love a pull request :) Or I can fix this eventually, but it could be a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants