Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test runner is broken #42

Open
q66 opened this issue Dec 16, 2023 · 4 comments
Open

The test runner is broken #42

q66 opened this issue Dec 16, 2023 · 4 comments
Assignees

Comments

@q66
Copy link
Collaborator

q66 commented Dec 16, 2023

I just noticed that the test runner does not actually fail on any failures.

@jvoisin
Copy link
Owner

jvoisin commented Dec 28, 2023

Fixed in f3c0bfd

@jvoisin jvoisin closed this as completed Dec 28, 2023
@jvoisin jvoisin self-assigned this Dec 28, 2023
@q66
Copy link
Collaborator Author

q66 commented Dec 28, 2023

that's not a fix, it's the make command that should exit with 1 if anything fails

@q66 q66 reopened this Dec 28, 2023
@jvoisin
Copy link
Owner

jvoisin commented Dec 29, 2023

I don't think there is an easy elegant way to make the makefile exit with 1 should a test fail, while making it run all the tests.

@q66
Copy link
Collaborator Author

q66 commented Dec 29, 2023

sure there is, you're already running a shell snippet, just make it a little bigger and if any of the tests returns non-zero, set a variable and if the variable is set at the end, error

or make it a separate helper script and invoke that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants