Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More standard time mocking using Clock #147

Open
crizzis opened this issue Nov 13, 2024 · 0 comments
Open

More standard time mocking using Clock #147

crizzis opened this issue Nov 13, 2024 · 0 comments

Comments

@crizzis
Copy link

crizzis commented Nov 13, 2024

SamlClient provides a way of mocking the timestamp using setInstantNow, which works just fine.

However, the standard way of mocking time in Java 8+ is to supply a Clock instance, which allows more flexibility, and eliminates the need of 'special' methods being exposed only for testing.

So, the suggestion here is perhaps SamlClient could expose setClock instead, which would be safe for calling both in production and test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant