Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollWheelZoom.enable() and disable() #1225

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add scrollWheelZoom.enable() and disable() #1225

merged 2 commits into from
Oct 21, 2024

Conversation

lopezvoliver
Copy link
Contributor

@lopezvoliver lopezvoliver commented Aug 18, 2024 •
edited
Loading

This pull request fixes #1224

Update: also fixes the same issue with other types of zoom:

  • doubleClickZoom
  • touchZoom
  • boxZoom

@lopezvoliver
Copy link
Contributor Author

@martinRenou, could you please have a look?

martinRenou
martinRenou approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 6903b7e into jupyter-widgets:master Oct 21, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating scroll_wheel_zoom doesn't affect existing maps.
2 participants
@lopezvoliver @martinRenou