Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve less favicons #64

Open
peterschewe opened this issue Feb 9, 2023 · 0 comments
Open

Serve less favicons #64

peterschewe opened this issue Feb 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@peterschewe
Copy link
Contributor

peterschewe commented Feb 9, 2023

The WEKit already does some things right and recommends only a few selected favicons - compared to the mass provided by favicon generators.

This article is a good guideline: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs#the-extremely-short-version

  1. Our manifest file already follows this recommendation and only references two icon sizes ✅
{
  "icons": [
    { "src": "/icon-192.png", "type": "image/png", "sizes": "192x192" },
    { "src": "/icon-512.png", "type": "image/png", "sizes": "512x512" }
  ]
}
  1. We can delete the favicon-32x32.png file and remove the reference in head.html.

  2. Link favicon.ico in head.html. Browsers actually automatically look in the root for the file, but we can then add a sizes="any" attribute. This fixes a bug on Chrome that otherwise prefers ICO instead of SVG.

  3. Our favicon.ico is 16x16 in size. Recommended is 32x32.

  4. TBD: Document this recommendation or link the article. Otherwise, the favicon generators are quickly used again.

@peterschewe peterschewe added the enhancement New feature or request label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant