Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto close settings is being ignored by the devtools protocol code. #7

Closed
june07 opened this issue May 19, 2024 · 12 comments
Closed

Auto close settings is being ignored by the devtools protocol code. #7

june07 opened this issue May 19, 2024 · 12 comments

Comments

@june07
Copy link
Owner

june07 commented May 19, 2024

#6 (comment)

@june07 june07 closed this as completed in 16fcfc9 May 19, 2024
@june07
Copy link
Owner Author

june07 commented May 20, 2024

@l-Nuril-l the newest version is 3.6.7 and it's available from the Chrome Webstore already, Edge is a little slower. Please confirm once you've tested it. Thanks.

@june07 june07 reopened this May 20, 2024
@l-Nuril-l
Copy link

Please confirm once you've tested it.

With the "Open in new window" option.
Now the page opens in my main browser, but when I edit the code, it just stops working.
If I close the tab the only way to open the page again is to restart the extension.
Also now the plugin version in the app doesn't match the real version.

@june07
Copy link
Owner Author

june07 commented May 21, 2024

Had some issues with the build pipeline.

See 3.6.9...

nimv3-issues-7

@l-Nuril-l
Copy link

l-Nuril-l commented May 21, 2024

Already looks functional.
But there are some problems:

  1. If you turn off "Make Window Focused." everything breaks.
  2. The application sometimes turns into a white screen.
    2.1 image
    2.2 image

Is it a limitation of Manifest V3 that you open a new tab first instead of rebooting (redirect)?

@june07 june07 closed this as completed in 02f10e8 May 21, 2024
@june07 june07 reopened this May 21, 2024
@june07
Copy link
Owner Author

june07 commented May 21, 2024

  1. The "Make Window Focused" issue has been resolved in the version I just pushed 3.6.10
  2. I have noticed this myself and I have opened a separate issue about this. I assume you mean the popup turns white/blank... and re-opening it (clicking the popup again) resolves the issue. I haven't yet been able to track down why this is happening.
  3. I get what you're saying about this one, and to answer your question, it's not a limit of the API I don't think (not absolutely sure yet) but just the way it was done. I get that it causes a bit of an unpleasant UI/UX... and the update I just made (2.6.11) seems to be an acceptable fix...

Old way:
nimv3-issues-7-beforeGroupFix

New way:
nimv3-issues-7-afterGroupFix

What do you think about the difference?
I will say I spent a bit of time trying to match the behavior exactly, but it started to become a time sink.

And thanks for your continued feedback on this!

@l-Nuril-l
Copy link

l-Nuril-l commented May 22, 2024

What do you think about the difference?

The old way is better as now the tab loses its position in ALT + TAB and opens at the very end.
In V2 version everything looks more correct, but actually I agree it's already prefectionism.

Everything else is working correctly, thanks for the updates!
I gave the extension 5 stars, don’t hide your rating)

@l-Nuril-l
Copy link

Doesn't work after restarting the browser.
A simple fix is to open "Inspect" from the extension.
https://github.com/june07/nimv3/assets/49325887/2d50353c-db08-43a3-aa5d-fbffd90af6d1

@june07
Copy link
Owner Author

june07 commented May 22, 2024

Thank you for the 5-star rating, much appreciated!

Doesn't work after restarting the browser.

I watched your screen capture and I'm pretty sure you're referring to this issue which has been ongoing! I've updated the install page to inform people about it and I wish Google would fix it because I'm sure a lot of folks thing NiM doesn't work and immediately de-install/dismiss.

@l-Nuril-l
Copy link

V2 RIP
image

What do you think about the difference?

Please roll back to the old way. 9aa1bba Thanks.

@june07
Copy link
Owner Author

june07 commented May 29, 2024

@l-Nuril-l
Copy link

@june07
Copy link
Owner Author

june07 commented Jun 20, 2024

@l-Nuril-l I wanted to circle back around to this issue before closing it out to say thank you again for working with me on this issue. I wish more developers provided similar valuable feedback about their own workflows and usage of NiM. It helps a great deal in understanding how to make it better and how to fix things that I don't necessarily see in my own workflows.

Anyway, thank you again!

This specific issue is resolve so I'm closing this out. Still have an eye on the other one.

@june07 june07 closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants