Here are some guidelines we'd like you to follow before submitting a PR.
Tailwind warns that you don't construct class names dynamically. Instead of this:
<div class="text-{{ error ? 'red' : 'green' }}-600"></div>
<div class="{{ error ? 'text-red-600' : 'text-green-600' }}"></div>
Please add a type to export
ed variables. When we generate props files, it will automatically pick up types from your file. If you don't add a type, it will break.
Please run the following to update prop files.
npm run gen:props
This script will update/generate files in src/routes/props
.
Again avoid type inference for export
ed variables.
Please put all export variables before functions to avoid breaking props tables.
Please don't send a large amount of changes at once. It takes time to go through all changes. It is easier to check and update the repo asap.
When making a commit, we recommend using the Conventional commits.
Some examples are:
feat: add rating component
fix: add if statement to Button component
chore: clean up About page
docs: add timeline page
style: update home page
test: add modal test
When you have a breaking change:
git commit -a "feat: change btnClass name to bClass" -m "BREAKING CHANGE: change the Button component attributes"
Before submitting a PR, please run a test:
npm run test