Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State of branch 'readers'? #5

Closed
Freeaqingme opened this issue Jul 26, 2019 · 2 comments
Closed

State of branch 'readers'? #5

Freeaqingme opened this issue Jul 26, 2019 · 2 comments

Comments

@Freeaqingme
Copy link

I stumbled on the branch 'readers'. It seems quite complete and neat. I realize it's been a while that you probably worked on this project, but do you remember if there's any reason why it's not merged to master?

Maybe that was never the intention, but if there are any bugs or other concerns that you had I'd be happy to hear about them (and potentially fix them) before putting it into production :)

Thanks!
@juli4n
Copy link
Owner

juli4n commented Jul 30, 2019

Hey Dolf, sorry for the late response! I'm glad you found this useful.
Honestly, I haven't had time to test it properly (it was just the result of a single pass) but I'll certainly appreciate if you want to take and send a PR. As you said, it should be pretty close.

@Freeaqingme
Copy link
Author

As you said, it should be pretty close.

Yeah, except for the CalculateDifferences(). That was a fun one to fix :)

Covered in PR #7 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Freeaqingme @juli4n