-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with mysql-connector-python 8.1.0 #914
Comments
This issue is marked as incomplete because it has been open 30 days with no activity. Please remove incomplete label or comment or this will be closed in 5 days. |
Still an issue |
@cderici would be interesting to run an experiment with a fork of py-macaroon-bakery with the constraint relaxed and see how things change. We could always submit a PR upstream and run on a forked dep until then? |
@jnsgruk yeah that's what I was thinking as well, addressing this soon 👍 |
Fixes juju#914 by using a fork of macaroonbakery that's introduced in go-macaroon-bakery/py-macaroon-bakery#90
@carlcsaposs-canonical could you please try out the #956 and confirm that it fixes this? Thanks! |
Sorry for the delay, still seeing issues:
Reproducible with canonical/mysql-operator#337 and or:
|
py-macaroon-bakery currently requires an old protobuf version, which is incompatible with other projects such as python-mysql-connector [1] or the Openstack global requirements [2]. Since the project is compatible with recent protobuf versions (4.24.x), we'll update the protobuf dependency to >=3.4,<5.0. [1] juju/python-libjuju#914 [2] https://github.com/openstack/requirements/blob/e54dc19f590bd0ea74fd2d7ada3d0d1b3321260b/upper-constraints.txt#L377C1-L377C18
This issue is marked as incomplete because it has been open 30 days with no activity. Please remove incomplete label or comment or this will be closed in 5 days. |
Still an issue |
The ceiling for @carlcsaposs-canonical could you please confirm? Thanks! |
@cderici what versions do you want me to test with?
if you want to test yourself, here are steps to reproduce: #914 (comment) or #914 (comment) |
@carlcsaposs-canonical Thanks for looking at this again, it was working for me, not sure what I've missed there in my local setup. It appears that I forgot to change the |
@cderici fyi it's also possible to test a branch with something like this |
@carlcsaposs-canonical Yeah I usually work with venv, didn't know how to do it with poetry, thanks for showing. Note that that branch is no longer needed since the upstream changed the protobuf requirements. go-macaroon-bakery/py-macaroon-bakery#92 is also landed and published on pypi. I tried again your steps and I'm able to install both |
looks like it's working in the simple reproduction also testing here with the charm: https://github.com/canonical/mysql-operator/actions/runs/7131287248?pr=337 thank you! |
Jumping in, we noticed that after macaroonbakery 1.3.3 has been published ,all of our CI tests have been failing in sunbeam. Such as https://github.com/canonical/snap-openstack/actions/runs/7131094652/job/19418941480?pr=65 Any pointers on how to resolve it since you seem to have them working ? |
So I tested pylibjuju with @fabricematrat can you please take look at the error that @gboutry mentioned above, is this something that needs to be fixed on the macaroonbakery? as the error mentions that some re-generation is needed:
@gboutry mentioned that pinning the protobuf to |
@carlcsaposs-canonical looks like your charm is failing with the same problem as well. |
It's not working with protobuf 4.21.7, a bad refresh of my venv led me to believe this |
Just for reference, reported this on the macaroonbakery repo go-macaroon-bakery/py-macaroon-bakery#92 (comment) |
I also raised this issue: go-macaroon-bakery/py-macaroon-bakery#94 |
Hi @cderici
I've checked and when it used to pass the |
I got multiple teams confirming that this problem is resolved after go-macaroon-bakery/py-macaroon-bakery#95 landed, @gabrielcocenza can you also confirm? @carlcsaposs-canonical It would also help if you can check this once again just to make sure since we had another release pushed for the macaroonbakery with that PR. Thanks! |
@cderici I confirm that the issue is solved. Thanks! |
@cderici which version/branch of libjuju do you want me to test with? |
@carlcsaposs-canonical Version of libjuju doesn't matter as both 2.9 and 3.x tracks have the same range for the macaroonbakery, but regardless, I don't observe this incompatibility (with mysql-connector-python) anymore in my tests (that get the latest macaroonbakery 1.3.4 that's released yesterday), so I'm gonna close this issue. Feel free to reopen if it persists. |
Appears to be passing on our end. Couple failing tests, but they look unrelated at first glance https://github.com/canonical/mysql-operator/actions/runs/7208377297?pr=337 |
python-libjuju is incompatible with mysql-connector-python 8.1.0 since python-libjuju depends on macaroonbakery, which hasn't been updated since Feb 2020 and depends on protobuf<4
mysql-connector-python depends on protobuf>=4.21.1
Details
Steps to reproduce:
poetry new foo
cd foo
poetry add mysql-connector-python^8.1.0
poetry add juju>=2
The text was updated successfully, but these errors were encountered: