Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jujubot auto-reply on external PRs needs love #1188

Closed
james-garner-canonical opened this issue Nov 14, 2024 · 9 comments
Closed

jujubot auto-reply on external PRs needs love #1188

james-garner-canonical opened this issue Nov 14, 2024 · 9 comments
Labels
area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority

Comments

@james-garner-canonical
Copy link
Contributor

Description

Current message:

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

Link 404s. The 'correct' link would be https://github.com/juju/juju/blob/main/doc/CONTRIBUTING.md, but even then there's a bunch of Juju specific information that doesn't apply here, such as "Bug reports should be filed on Launchpad, not GitHub".

We should link to python-libjuju CONTRIBUTING.md instead, but at the very least that should be updated to explain the juju conventional commits convention, e.g. linking here.

Also it seems to double post? (See here and here).

Also it should probably ping someone else, like @dimaqq and I.

Urgency

Casually reporting

Python-libjuju version

main

Juju version

n/a

Reproduce / Test

...
@james-garner-canonical james-garner-canonical added kind/bug indicates a bug in the project kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) and removed kind/bug indicates a bug in the project labels Nov 14, 2024
@Srijan-SS02
Copy link

Hello @james-garner-canonical, it looks like the repository to jujubot is not a public repository, or am I looking in the wrong place?

Also, there is a slight typo in the doc for git add upstream [email protected]:juju/python-libjuju.git which should be git remote add here

Happy to contribute if there is any way you can provide access to the repo or direct me to the correct source if I am looking in wrong place.

@james-garner-canonical
Copy link
Contributor Author

Thanks for taking an interest in this issue, @Srijan-SS02. Are you a user of python-libjuju?

I think you're right about jujubot, I suspect its configuration is private by design, so we'll have to fix this one internally.

Thanks for catching that docs typo! I'll take care of the docs portion of this shortly.

jujubot added a commit that referenced this issue Nov 20, 2024
…ate-contributing-md

#1201

To support improving the jujubot auto-reply on external contributor PRs (see #1188), update our CONTRIBUTING.md to be a good landing page to be linked to. Also fix an error in a git command [noticed by a contributor](#1188 (comment)).

#### QA Steps

Proofread docs.

#### Notes & Discussion

Need to look into how to update jujubot config for this repo.
@hpidcock
Copy link
Member

I've turned this off across all juju org projects.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 20, 2024

Let's close this after next external PR when we're sure that the bot is gone.

@james-garner-canonical
Copy link
Contributor Author

james-garner-canonical commented Nov 20, 2024

Thanks, Harry, that solves the issue.

@dimaqq I'll update the PR template with the information we want new python-libjuju contributors to see -- conventional commits convention (names), requirement for signed commits and CLA, and that a maintainer will have to run /build. Anything else?

@Srijan-SS02
Copy link

Thanks for taking an interest in this issue, @Srijan-SS02. Are you a user of python-libjuju?

I think you're right about jujubot, I suspect its configuration is private by design, so we'll have to fix this one internally.

Thanks for catching that docs typo! I'll take care of the docs portion of this shortly.

Hello @james-garner-canonical, I was exploring more about juju and found this repo of python-libjuju. Not a regular user but still happy to contribute.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 22, 2024

@Srijan-SS02 there's whole bunch of "help-wanted" issues.

If you want to help, you'll need to set up Juju and LXD and/or MicroK8s. Some of it takes time, but there are docs and it's a great introduction to Canonical ecosystem.

I see that you're already involved with Ubuntu. Compared to that, the Juju world is oriented more towards production and attracts notably fewer users, which means relying on (and improving) official docs rather than, say, stackoverflow and more hard work in general. Totally worth trying, if you ask me!

@Srijan-SS02
Copy link

Srijan-SS02 commented Nov 23, 2024

Hi @dimaqq Thanks, for the suggestion and the thoughtful encouragement! This sounds good and challenging to me, I definitely am going to give it a try. I have been more into DevOps and Python side so far in my career, so production work aligns with my skill set.

Is there any official channel to communicate like slack or any other?

@dimaqq
Copy link
Contributor

dimaqq commented Nov 23, 2024

We’re all on matrix. It’s documented in docs/contributing.md

@dimaqq dimaqq closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nonpython Pull requests that updates non-Python code (bash, Makefile, etc.) kind/CI About CI infra or tests kind/doc indicates a documentation change priority/normal normal priority
Projects
None yet
Development

No branches or pull requests

4 participants