Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to python3.12 #1088

Closed
Aflynn50 opened this issue Aug 8, 2024 · 2 comments
Closed

Update CI to python3.12 #1088

Aflynn50 opened this issue Aug 8, 2024 · 2 comments
Labels
hint/3.x going on main branch kind/test invalid or failing tests cases, build errors due to a test case, any problems regarding testing. priority/urgent require urgent attention

Comments

@Aflynn50
Copy link
Contributor

Aflynn50 commented Aug 8, 2024

Description

It is currently impossible to merge PRs with the /merge command due to a dependency on a python3.11 which tox is now unable to install.

Urgency

Casually reporting

Python-libjuju version

2.9, 3.5

Juju version

NA

Reproduce / Test

NA
@hmlanigan hmlanigan added hint/3.x going on main branch priority/urgent require urgent attention kind/test invalid or failing tests cases, build errors due to a test case, any problems regarding testing. labels Aug 15, 2024
@dimaqq
Copy link
Contributor

dimaqq commented Sep 19, 2024

I wonder if @jack-w-shaw fixed this or worked around it in some other way?

jujubot added a commit that referenced this issue Sep 23, 2024
#1106

#### Description

Pin python kubernetes version to fix recent breakage in jenkins tests.

The latest update to the python kubernetes library (v31, 3 days ago) breaks the Jenkins `github-check-merge-juju-python-libjuju` test due to failure to build a new dependency (durationpy).

I thought this might be the fix for issue #1088, but that's been open since August 9. Should we switch to stricter dependency versioning across the board here to avoid breakages of this nature? In setup.py, 4 dependencies now specify both minimum and maximum versions, 5 only specify a minimum, and 2 have no version specification. In tox.ini, only 1 dependency (kubernetes) specifies a (maximum) version. tox.ini should probably have the same version constraints as setup.py.


#### QA Steps

All tests pass, except for integration tests, which are flaky (see issue #1108).
@james-garner-canonical
Copy link
Contributor

Closed due to /merge working now (fixed in #1106 -- or earlier?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint/3.x going on main branch kind/test invalid or failing tests cases, build errors due to a test case, any problems regarding testing. priority/urgent require urgent attention
Projects
None yet
Development

No branches or pull requests

4 participants