From c7abedc2fac70aaae3048eb137d16690a4c7553c Mon Sep 17 00:00:00 2001 From: Dima Tisnek Date: Thu, 17 Oct 2024 12:57:17 +0900 Subject: [PATCH] ci: udpate continue markers and explain why --- .github/workflows/test.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 44e0fe17..276005f6 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -114,7 +114,7 @@ jobs: # * test_ssh # * ... # - "3.6/beta" - continue-on-error: false # don't ignore if tests against some juju version fail + continue-on-error: false # ultimately fail a run if one of the matrix combinations fails steps: - name: Check out code uses: actions/checkout@v4 @@ -158,7 +158,7 @@ jobs: - name: Run integration # Force one single concurrent test run: tox -e integration - continue-on-error: true # so that other juju versions are tested + continue-on-error: true # don't fail early, let other matrix combinations get tested integration-quarantine: name: Quarantined Integration Tests @@ -174,6 +174,7 @@ jobs: - "3.3/stable" - "3.4/stable" - "3.5/stable" + continue-on-error: false # ultimately fail the run if one of the matrix combinations fails steps: - name: Check out code uses: actions/checkout@v3 @@ -188,4 +189,4 @@ jobs: juju-channel: ${{ matrix.juju }} - name: Run integration run: tox -e integration-quarantine - continue-on-error: true # so that other juju versions are tested + continue-on-error: true # don't fail early, let other matrix combinations get tested