You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
However the source directory takes 86 MB and isn't really necessary for the charm. Without it the charm is in total around 11 MB. If I remove it and upgrade the charm it works perfectly without it. So do we really need this directory?
If you like I can donate some time for a PR to add a build flag. Copying the 'assets' (
The reason why my source directory is so large is because it also has some files that are not compiled into the binary. But none the less it seems like a nice feature to have.
The text was updated successfully, but these errors were encountered:
I'd accept a PR that added a -no-source flag that caused the source package
directory copying to be omitted.
If specified and the assets directory exists in the package source, instead of
symlinking the assets directory, it would just create a direct copy in the top level
of the charm directory.
It would be nice to build a charm without 'src' directory. If I build my project with gocharm the resulting directory looks like this:
However the source directory takes 86 MB and isn't really necessary for the charm. Without it the charm is in total around 11 MB. If I remove it and upgrade the charm it works perfectly without it. So do we really need this directory?
If you like I can donate some time for a PR to add a build flag. Copying the 'assets' (
gocharm/cmd/gocharm/main.go
Line 213 in ee7a68e
The reason why my source directory is so large is because it also has some files that are not compiled into the binary. But none the less it seems like a nice feature to have.
The text was updated successfully, but these errors were encountered: