Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass null if no req.rawBody #143

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Sep 16, 2021

Summary

Pass rawBody:null to SvelteKit render(req) function as per the changes in https://github.com/sveltejs/kit/pull/2299/files#diff-418712fdcdc80e8bf5cc0e519480d6bc0178a372c82aa3675dddd4870a5988a6R25

Fixes: #127

Other Information

As per firebase/firebase-functions#959 the firebase-functions.https.Request type does not align with the upstream Functions Framework type and req.rawBody from Firebase is actually optional, so can be nullable, unlike the type information in VSCode indicates.

@jthegedus jthegedus merged commit 15c9ca4 into main Sep 16, 2021
@jthegedus jthegedus deleted the fix/use-empty-rawbody-w-get branch September 16, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: rawBody on empty request.body
1 participant