Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync with [email protected] #194

Closed
wants to merge 10 commits into from
Closed

fix: sync with [email protected] #194

wants to merge 10 commits into from

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Dec 14, 2022 •
edited
Loading

Summary

Sync SvelteKit to latest alpha version @sveltejs/[email protected]

Other Information

todo:

@jthegedus jthegedus changed the title chore: bump asdf tools fix: sync with kit 1.0.0-next.587 Dec 14, 2022
@jthegedus jthegedus changed the title fix: sync with kit 1.0.0-next.587 fix: sync with [email protected] Dec 14, 2022
@jthegedus
Copy link
Owner Author

jthegedus commented Dec 14, 2022 •
edited
Loading

Failing end-to-end test may be because of #190 as the test is of a static page - Omit prerendered routes from server manifest

I guess it is good that the end-to-end test managed to capture the issue.

If someone sees this before this PR is merged, feel free to help out, I am very busy at the moment.

@jthegedus jthegedus added the help wanted Extra attention is needed label Dec 14, 2022
@jthegedus jthegedus mentioned this pull request Dec 14, 2022
Closed
@simpros
Copy link

simpros commented Dec 19, 2022

@jthegedus do you think this MR also fix the adapter for svelte-kit 1.0?
I just updated and sadly it does not compile anymore 🤔

@jthegedus
Copy link
Owner Author

@CodeCakePie yes, this should resolve 1.0.0 issues, though the static route issue needs to be solved still before merging.

For those reading who may be able to help, i believe we want to update firebase.json by adding the static routes into the headers section before deployment. The solution should be similar in effect to the vercel or netlify adapters.

Feel free to pr to the branch this pr is from.

@pham pham mentioned this pull request Jan 16, 2023
Merged
@jthegedus jthegedus closed this Jan 17, 2023
jthegedus added a commit that referenced this pull request Jan 17, 2023
@jthegedus
Revert "chore!: Sync with [email protected] based on (PR #194 & #200) (#201)"
d3dcd85 
This reverts commit e933b92.
jthegedus added a commit that referenced this pull request Jan 17, 2023
@jthegedus
Revert "chore!: Sync with [email protected] based on (PR #194 & #200) (#201)"
1a3cae9 
This reverts commit e933b92.
jthegedus added a commit that referenced this pull request Jan 17, 2023
@jthegedus
chore(revert): Sync with [email protected] based on (PR #194 & #200)" (#202)
7f757f7
@jthegedus jthegedus mentioned this pull request Jan 17, 2023
Merged
jthegedus added a commit that referenced this pull request Jan 17, 2023
@jthegedus @pham
fix!: sync with [email protected] based on (PRs #194 #200) (#203)
352072d 
* chore: bump asdf tools

* chore: bump dependencies

* chore: apply xojs fixes

* test: bump test functions to nodejs18

* test: bump test deps & devdeps

* fix: rm check of runtime version assume nodejs18

* docs: update compat table

* test: fix end-to-end test firebase config

* chore(deps): Bump kit v1.1.1; ava, xo, esbuild, firebase-functions

* fix(lint): Use explicit `import type` statement

* fix(lint): Use the preferred nullish coalescing op over ternary

* test(version): Switch to `checkout@v3` to get rid of Node.js 12 warnings

* feat: Add Node.js 18 support

* fix: Missing 2nd argument for  (reading 'prerendering' error)

* fix(#200/@AndrewLester): Write prerendered fiels to public directory

* test(version): Add Node.js 18 to test cases

* fix(test): Add static route for `/about`. Switch from Svelte demo -> sverdle

* fix(test): Missing quote in `firebase.json`. Change label in test from Todos to Sverdle

Co-authored-by: Paul Pham <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: [breaking change] sveltekit 1.0.0-next.539
3 participants
@jthegedus @simpros @pham