Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't render an image from the attachments section #53

Open
karnilaev opened this issue Feb 22, 2024 · 1 comment
Open

Doesn't render an image from the attachments section #53

karnilaev opened this issue Feb 22, 2024 · 1 comment

Comments

@karnilaev
Copy link

karnilaev commented Feb 22, 2024

Hello,

The library doesn't render files with an image from the attachments section correctly.
An example of the file:
example.ipynb.zip

Here is how the Visual Studio Code renders the example:
CleanShot 2024-02-22 at 18 16 26

And here is how the nbpreview renders the example:
CleanShot 2024-02-22 at 18 21 28

@jsvine
Copy link
Owner

jsvine commented Mar 2, 2024

Thanks for flagging this, @karnilaev. I agree: notebookjs should handle these, given that they're in the official notebook spec. Do you or does anyone else in the community have interest/availability to contribute this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants