Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Rails <5 #16

Open
nikolasgd opened this issue Nov 13, 2020 · 2 comments
Open

Doesn't work with Rails <5 #16

nikolasgd opened this issue Nov 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@nikolasgd
Copy link

Great little tool!

It doesn't work in Rails 4 projects as the test command there is "rake test" (not "rails test"). Maybe that could be made a configuration option or the Rails version could be auto detected.

@jsrn
Copy link
Owner

jsrn commented Nov 13, 2020

Thanks! Good catch. :)

Off the top of my head, automatic version detection sounds like a better approach. 🤔

@jsrn jsrn added the bug Something isn't working label Nov 13, 2020
@nikolasgd
Copy link
Author

Definitely version detection is the way to go. I would probably get the version from the Gemfile. Sorry I have no experience with vs code extensions and don't feel fit to make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants