fix for wrong audio mimetype preventing playback in Safari #2991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While preparing an experiment using the html audio response plugin, I found out that playback of recorded audio (using
{allow_playback: true}
) doesn't work in Safari (tested on 16.3).This happens because the audio mimetype is hardcoded as "audio/webm" while Safari is using mp4. From what I've seen, Chrome is indeed recording webm, and Firefox seems to work regardless of this mismatch.
Anyway, the fix here would be to just use whatever is provided in
recorded_data_chunks
.Thanks!