Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for wrong audio mimetype preventing playback in Safari #2991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbonf
Copy link
Contributor

@bbonf bbonf commented Mar 24, 2023

Hello,

While preparing an experiment using the html audio response plugin, I found out that playback of recorded audio (using {allow_playback: true}) doesn't work in Safari (tested on 16.3).
This happens because the audio mimetype is hardcoded as "audio/webm" while Safari is using mp4. From what I've seen, Chrome is indeed recording webm, and Firefox seems to work regardless of this mismatch.

Anyway, the fix here would be to just use whatever is provided in recorded_data_chunks.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

⚠️ No Changeset found

Latest commit: cc1ca25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant