🐛 Bug: Mis-linked page (Again)

[IyaadDev]

Describe the bug

This line of code

const markdownFile = '_indexPage';

is faulty, every page with this code which has a "Contribute to this on GitHub" redirects to https://github.com/json-schema-org/website/blob/main/pages/{url}/_index.md , which is a 404.

Steps To Reproduce

Example:

1. Navigate to https://json-schema.org/overview/faq
2. Click on the Contribute to GitHub button
3. Arrive at https://github.com/json-schema-org/website/blob/main/pages/overview/faq/_index.md (404)
4. Error reproduced

Expected Behavior

A 200 response on the editable source code page.

Screenshots

No response

Device Information [optional]

- OS: Ubuntu 20.04 Noble
- Browser: Firefox, Chrome
- version: 22

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

[DhairyaMajmudar]

Thanks @IyaadDev for reporting the issue

[DarhkVoyd]

@IyaadDev Hey, Could you skim over the docs pages and also check if this is broken somewhere else too, to avoid redundant similar issues and possibly fix this everywhere?

[RonakSurana-2001]

Can I work On resolving this issue

[RonakSurana-2001]

This is also happening on https://json-schema.org/overview/use-cases

[IyaadDev]

Yep, will be posting links affected with this tomorrow

[IyaadDev]

Several pages have this faulty code snippet,

[DhairyaMajmudar]

The component here is used into layout so if there's problem on one page it will be problem in other corresponding pages as well.

[arpitkuriyal]

@DhairyaMajmudar I can do this can you assign this to me?

[IyaadDev]

I've looked at all the pages which contain this variable with the assigned value before:

const markdownFile = '_indexPage';

Some of the links correctly return the source code, others return page not found.

Here are the links which use the markdownFile as _indexPage

---

https://json-schema.org/learn

Contribution: https://github.com/json-schema-org/website/blob/main/pages/learn/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/learn/index.page.tsx

---

https://json-schema.org/overview/case-studies

Contribution: https://github.com/json-schema-org/website/blob/main/pages/overview/case-studies/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/overview/case-studies/index.page.tsx

---

https://json-schema.org/specification/migration

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/migration/_index.md (Correct)

---

https://json-schema.org/understanding-json-schema

Contribution: https://github.com/json-schema-org/website/blob/main/pages/understanding-json-schema/_index.md (Correct)

---

https://json-schema.org/overview/use-cases

Contribution: https://github.com/json-schema-org/website/blob/main/pages/overview/use-cases/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/overview/use-cases/index.page.tsx

---

https://json-schema.org/specification/release-notes

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/release-notes/_index.md (Correct)

---

https://json-schema.org/specification/json-hyper-schema

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/json-hyper-schema/_index.md (Correct)

---

https://json-schema.org/understanding-json-schema/reference

Contribution: https://github.com/json-schema-org/website/blob/main/pages/understanding-json-schema/reference/_index.md (Correct)

---

[IyaadDev]

I'll be submitting a pr soon with a fix for affected pages

[Yashwanth1906]

I have cleared the bug. Can i send a pr?

[IyaadDev]

Sure, @Yashwanth1906
waiting for @Yashwanth1906 for a pr,

[Yashwanth1906]

I need a small help. Im struck with this error when I'm trying to commit to my forked repo.

git commit -m "link-redirect-fix"
Performing code styling, testing, and building processes before committing
error This project's package.json defines "packageManager": "[email protected]". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.
ESLint Check Failed. Run yarn run lint:fix, Review the listed issues, make the required adjustments, add the changes, and attempt to commit again.
husky - pre-commit script failed (code 1)

can u pls help me with this? Sry Im completely new to open source.

[arpitkuriyal]

@Yashwanth1906 i also faced this while i was setting up the repo . you can solve it by enabling corepack .Try "enable corepack " then see the version of the yarn if it is showing 4.4.0 than you are good to go and if you still see the yarn version 1.22.22 you should first uninstall yarn then try it again

[Yashwanth1906]

@arpitkuriyal Thank you so much for helping me out.

[Yashwanth1906]

Waiting for the feedback!

[Yashwanth1906]

@DhairyaMajmudar I have created a new pull request making all the changes you specified

[Yashwanth1906]

Waiting for you feedback!

[DhairyaMajmudar]

@DhairyaMajmudar I have created a new pull request making all the changes you specified

Thanks! but you ne need to again fork the repo and create a new pull request to do the suggested changes you can commit the change in the same branch using git commands : )

[Yashwanth1906]

@DhairyaMajmudar Ok sure

[Yashwanth1906]

@DhairyaMajmudar I have sent a pr. Waiting for your feedback!

[IyaadDev]

@Yashwanth1906 could you link the pr here pls?