-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_tools] Add node to publish diagnostics based on topic and node status #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iory
requested changes
May 11, 2022
iory
requested changes
May 12, 2022
This looks good! |
708yamaguchi
force-pushed
the
sanity-diagnostics
branch
from
May 12, 2022 13:51
02825c4
to
088a62f
Compare
Sorry for force-push. |
This looks good. |
Thank you! I updated the code and fixed the test error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node checks topic and node status and publishes
/diagnostics
topic.I refine jsk-ros-pkg/jsk_robot#1460 by using
sanity_lib.py
.https://github.com/jsk-ros-pkg/jsk_common/blob/a3d26ac5243c108cec25d4108d93b3f0fd57c503/jsk_tools/src/jsk_tools/sanity_lib.py
In the future, I think robot speaks
/diagnostics
topic with this script.#1607