Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line endings #81

Open
XhmikosR opened this issue Nov 9, 2013 · 4 comments
Open

Line endings #81

XhmikosR opened this issue Nov 9, 2013 · 4 comments

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 9, 2013

It appears fixmyjs always uses LF. This is a problem on Windows at least.

@albertjan
Copy link
Contributor

If you have an editor even slightly better then notepad it'll deal with the line endings won't it? :neckbeard:

@XhmikosR
Copy link
Contributor Author

The problem isn't the editor, obviously. The problem is that git recognizes the files as modified.

@goatslacker
Copy link
Member

hmm I'll have to investigate. I'm using node's fs.writeFileSync with utf-8 encoding for writing files and I try not to monkey around with any of the files that are touched too much.

@CraigWarford
Copy link

So, apparently, it doesn't always use LF... If the comment block is a multi-line /**/ block, it will leave the CRLF in there, giving you a mix. Can we get a fix for that?

Perhaps, if it could detect the first instance of either LF or CRLF, and use that consistently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants